timothybonci
timothybonci
Yep, I missed that test locally. Thanks for kicking off the workflows, and thanks for fixing the git config in the .github ci. I'll fire up the debugger.
Aha, there was a bug in the internal caller in lib/commands/version.js where we were passing the flag instead of the option property, so we were never properly overriding gitTagVersion with...
@lukekarrys would you please approve the test workflows to test the latest changes?
Rebased to latest and fixed the two outstanding lint issues.
Rebased to latest again. @lukekarrys could you review?
> git is mocked in the tests - we don't use the package there. `'@npmcli/git': gitMock`
@fernandopasik I opened a PR into yours with what I hope are the right changes for the tests. I'm a GitHub noob, so this may have been a dumb way...
How do we get the tests re-run? It looks like they only run once on PR open, but not on subsequent pushes, at least automatically. Are we waiting on a...
I see failed tests from yesterday - it's not obvious to me why they're failing. I cloned the repo and can try and debug them, but I may not get...
Just needed a good night's sleep. https://github.com/fernandopasik/cli/pull/2 fixes the tests.