Tim Graham
Tim Graham
Can you add a regression test?
(flake8 failure preceding this PR addressed in https://github.com/brutasse/django-ratelimit-backend/pull/46)
This was completed in 4c3e2679f3b14102fbb2aad3082a790cbed7ca94.
You could also point people back to the [original django-registration](https://github.com/ubernostrum/django-registration) which is maintained again.
It's the original project from which django-registration-redux was forked. James Bennett is a Django core developer, so I think it's trustable.
Yes, testing was added in d40f6604d157574d61d1871ec55df2ef08d29db8.
Okay. By the way, I'm not a maintainer of this project.
Most of these tests are failing on CockroachDB due to ordering differences in the results, e.g. ``` ====================================================================== FAIL: test_exclude (expressions_window.tests.WindowFunctionTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tim/code/django/tests/expressions_window/tests.py", line...
Correct, but I'm not sure if the SQL standard says that the order by in the inner query is guaranteed to carry over to the results of the outer query?
I think I'll raise the issue with CockroachDB and see if they might consider changing the behavior since they often like to mimic PostgreSQL.