Tim Campbell
Tim Campbell
This is fantastic, and the significantly-shortened build times are a huge bonus. Thank you for putting this together!
(Sorry for the huge delay in getting around to this) Generally I think this is a great idea. The values look good to me, I just want to ping @renchap...
So we had a discussion internally about this. Generally it's a good idea to allow the customization of healthcheck endpoints. But there are two concerns with this particular implementation: -...
@24367dfa We have! That's one thing the new repository will be able to do. The way the current repo is set up doesn't allow this. @WyriHaximus Ideally yes, but we...
PR #175 was just merged, which merges this as well, so closing this~
Awesome, thank you! Could you add a little note to `CHANGELOG.md`, and then I can approve it 🙂
As far as I can tell this should be fine, though @renchap is more familiar with exactly how this work, and can confirm whether this should be alright.
If we want to remove `DB_POOL`, I just opened PR #190, which should accomplish that.
Just merged #190 which removes `DB_POOL` entirely, so considering this closed as a result.
@jeremiahlee Nope everything is good! Apologies for the delay :slightly_smiling_face: