Til Schneider
Til Schneider
I think you are referring to the typings of `@types/pbf` which [are defined here](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/pbf/index.d.ts)? I didn't change the internal implementation of `read` and `write` - it is the same as...
Yes, I think so, too. This is clearly a bug in `@types/pdf`. As you wrote, `obj` and `pbf` are not optional.
Could you open a pull request with this change in `@types/pbf`?
> Yep, though I'm not really sure about all the types. You might want to double check it yourself. E.g. are the `?`s here correct? > > ``` > writeRawMessage(fn:...
> My only suggestion is to add `/* tslint:disable */` at the start of the file because there are quite a few warnings otherwise (empty blocks, unbraced `if`s, line length)....
Regarding `null` vs. `undefined` in sub-messages I agree with you: This should be changed in pbf. Thanks for [your pull request](https://github.com/mapbox/pbf/pull/112)!
The change in the "normal mode" - I mean "each top-level message is generated into a single object literal" - is already covered by the existing tests. Testing the output...
From my perspective it's done...
Can you post the code snippet which is complained by TypeScript? Sure, you can send me a PR if you already have a fix.
This whole project looks pretty dead to me. The last release was in Nov 2019. This pull requests is soon one year old and none of the project owners doesn't...