Tiffany Tang comments

Results 8 comments of


                                            Tiffany Tang

[REVIEW]: simChef: High-quality data science simulations in R

Regarding https://github.com/Yu-Group/simChef/issues/174 My apologies for the delay! I am working on this issue and will hopefully have an update next week. Will keep everyone posted. Thanks!

[REVIEW]: simChef: High-quality data science simulations in R

Following up on https://github.com/Yu-Group/simChef/issues/174: I opened PR https://github.com/Yu-Group/simChef/pull/181 to address the comments from @rcannood discussed in https://github.com/Yu-Group/simChef/issues/174. We plan to merge ithese changes soon, pending review from co-authors. Thanks for...

JOSS paper

Thanks so much, James! Great first draft! Some comments below. Feel free to ignore if you think it's beyond the scope of this paper or unnecessary. In the code chunk,...

`create_sim`: functionality and naming consistency

> * **Naming**: We have many `create_*` functions that create `R6` objects like the `Experiment`, `DGP`, and `Method` classes. On the other hand, we used `init_docs()` for setting up the...

`verbose` argument to `simChef.verbosity` option

@jpdunc23 Looks good to me!

`verbose` argument to `simChef.verbosity` option

@jpdunc23 Is this completed?

More flexible per-visualizer `ggsave()` args and `Visualizer` filtering with `export_visualizers()`

I like the idea of making `export_visualizers()` such that it allows for saving only specific `Visualizer` outputs. Besides the `height` and `width` arguments though, do you see a use case...

More flexible per-visualizer `ggsave()` args and `Visualizer` filtering with `export_visualizers()`

Got it ok. Well I think creating a separate `.ggsave_options` is fine by me!