Tiffany
Tiffany
> I wonder if it might be better to simplify the password generation code: > > ``` > Create a bag of characters > For each type of character required...
hey @Zeragamba - have made some changes to ensure that we get the correct number of each character. noticed that the it currently does not error when max_length < min_length...
> I still feel like the password generation can still be made a lot simplier. > > There's lots of extra work to keep track of the number of different...
thanks @stefannibrasil! will also update the docs 👍
> hi @tiff-o this is looking like it's going in a great direction. Do you need any help? I'd love to see your work merged. Thanks! hey @stefannibrasil - thanks...
it looks like this occurs when both `mix_case` & `special_case` is true as `special_case` can currently override the characters that were changed by `mix_case`. have a rough solution that seems...
Hi @stefannibrasil - so sorry for the delay. Yes, I was able to reproduce the issue and found #2308 did not resolve. I haven't the chance to revisit this just...
thanks @stefannibrasil! no problem - am currently working on trying to simplify `def password` overall following feedback from the PR :)
> hey @tiff-o I think this PR is in a good shape to be merged after it's rebased. Any other improvements can be done in a follow up PR (we...
> amazing, will do. thanks @stefannibrasil!