Etienne Samson

Results 135 comments of Etienne Samson

I'm seeing the same thing, while running Xcode (I think), consistent 90+% CPU usage. Here's a few captured stack traces in case this helps… [BlockBlock-2.txt](https://github.com/objective-see/BlockBlock/files/6442690/BlockBlock-2.txt) [BlockBlock.txt](https://github.com/objective-see/BlockBlock/files/6442693/BlockBlock.txt)

@jamesmusgrave May I ask what was the point of adding that option ? Here it doesn't seem to change anything (resize and crop work just as well, it only clobbers...

After running a few tests here, I can't understand why the change was done : GIF images are perfectly resized and cropped without the code added by #20.

So, just for kicks, I've rebased the rest of the shallow code on top of that, and pushed it [here](https://github.com/libgit2/libgit2/compare/master...tiennou:feature/fetch-negotiate-depth-post-pks), and it broke the only testcase I had 😉. It...

> Is the ordering of them important to anything? AFAIR, it does not matter — the server will skip whatever we tell it as part of its revwalk. It's only...

> Could very well be though that I screwed up the parsing part while refactoring to use our own parser. Do you have a simple test grafts file that the...

> I honestly don't get it, sorry. That's strange, I was getting *one* failure, on the mkfile-based testcase, because of an expected space after the graft OID. I have no...

I share the concerns, and I agree we don't want to push more design work here until the protocol part is more fleshed out (as you say, refresh & lifecycle...

I can confirm that something is fishy, here's the [output](https://travis-ci.org/github/libgit2/objective-git/jobs/771143695#L1510) from a run of libgit2/objective-git, that builds with `SDKROOT\=/Applications/Xcode-12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk` and `MACOSX_DEPLOYMENT_TARGET\=10.10`.

It's not, but it might be easy to add. A new `aliases` section in the config, a pre-process step before markdown-ification. I'd personally have gone for taking a `files` section...