Taketomo Isazawa comments

Results 10 comments of


                                            Taketomo Isazawa

https://github.com/microsoft/KBLaM/pull/33 - I think this PR solves the dataset-loading? Please let me know if that's not the case.

Sorry about this dropping the ball on this, could you please ping me again? :)

Thank you @xidulu for the explanation. Closing issue for now, @lucasjinreal please let us know if you need more clarifications.

Does this issue still stand? If not I'll close this week.

Thanks Xi for tagging me, I'll open a PR

https://openreview.net/forum?id=aLsMzkTej9&noteId=vdhJEqlMUN -- here's some results with phi-3 from our discussion during paper review

I believe this is solved by sticking with huggingface 4.46.0 in #40 . Could you let me know if that's fixed things?

Now pinned to 4.46.0 in #40. Does this solve these issues?

Thanks, let me make a PR pinning to transformers 4.46.0. We'll consider longer-term solutions as well in the meantime