Thom Heymann

Results 12 comments of Thom Heymann

Hi @Luismahou Is this project still maintained? Would be good to get your input.

i think removing the constants would have a lot of advantages even allowing multiple different transfer and filter directories for different models.. however as mentioned i think that if we...

What's the reason for moving this component into a separate package?

> > What's the reason for moving this component into a separate package? > > Good question. The user profile works was migrated in #139247 so the component will be...

Discussed this with @isaclfreire further and we decided to leave these links in the top nav until we've got consensus about where they should live inside the Discover app. We've...

> @thomheymann Thank you for your detailed improvement requests! We'll look into each of them, see how complicated the changes would be and we'll put them on our regular development...

Thanks for explanation and fix Greg! I'm happy to use this for the time being but am a bit worried about having two different approaches in Kibana now (auto mocking...

Awesome, happy to go with the serializer approach! To be honest I'm not sure a `data-is-mocked` attribute would have helped in this case. The id 'generated-id' was pretty clearly named...

I might be missing some context but one other issue I thought about when discussing this with my team is that we might be trying to solve a problem here...

@constancecchen Amazing, thanks for looking into this! We currently have to manually overwrite the EUI mock in every unit test to create a unique id. I still think EUI should...