Thom Chiovoloni
Thom Chiovoloni
Yeah, I hit this issue too. I think ideally `--manifest-path` made cargo do the right thing here, although I guess that would be a breaking change, and I can see...
My main question would be: do the `BStr` and `BString` types pull their own weight? They feel a bit redundant to me -- I essentially only ever use the former...
Yep, that all makes sense to me, and I hadn't considered point 1 at all.
> Are you certain? Have you benchmarked it? If you search (or split, in this case) with a string containing exactly one byte, then memchr is exactly what's invoked. Ah,...
I took a quick stab at improving it by replacing https://github.com/BurntSushi/bstr/blob/master/src/unicode/whitespace.rs#L7 with this: ```rust pub fn whitespace_len_fwd(slice: &[u8]) -> usize { let mut i = 0; while i < slice.len()...
`getFramebufferAttachmentParameter` would be useful too, for use with `FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING` (which is already a constant that's exposed). If we wanted to handle things properly without explicit configuration in the imgui-glow-renderer, we'd...
Hm, that seems reasonable, and not too difficult to add I'd accept a patch for it, or I can try and get to it next weekend probably.
Actually, I think I'd like to spend a little time thinking about the interface specifically, so don't submit a patch unless you're willing to work through that. I'll try and...
Hm, yeah, it would be a nice addition.
Yeah, that would be fine, since they seem fairly semver-stable. If there are issues I can take a stab at it as well.