Thomas Frössman

Various problems with the .Files map

5

## 1. Directories are not included in the archive I was just using the Files map to add in extra files.. ```go ...Files = map[string]string{ "somefile":"/usr/share/doc/someproject/somefile", } ``` This fails...

Use subcommands library + support for flags via env

5

This also fixes a number small bugs in the earlier main.go The subcommands package adds some verbosity to the code but it also adds structure to the command/flag stuff. By...

``` $ dpkg --contents testpackage-0.0.1-amd64.deb -rwxrwxr-x root/root 4028490 2017-06-11 14:39 usr/bin/drone-deb $ dpkg --info testpackage-0.0.1-amd64.deb new debian package, version 2.0. size 1435764 bytes: control archive=366 bytes. 1 bytes, 0 lines...

It's a good idea to vendor all dependencies locally for building the executable to ensure reproducible builds and not fail if something external changes.

stdlib log.SetOutput does not work with the *Middleware's

1

Suggested change: Default to make a function call to log.Print instead of creating new logger if *AccessLogMiddleware.Logger is nil. It seems like it's a very uncommon pattern to create new...

support pt (the platinum searcher)

23

ag/pt are quite close to eachother featurewise. It might be a good idea to have support for both in the same codebase. Currently pt does not have all of the...

Http404 exceptions makes django_http_exceptions_total_by_view a bit useless

2

I would like to not have `Http404` registered by the exception counters because it's not a "hard" kind of error and `django_http_exceptions_total_by_view` becomes a bit useless to use properly beacuse...

Install/activation fails if virtualenvwrapper is installed globally

6

this happens: Requirement already satisfied (use --upgrade to upgrade): virtualenv in /usr/local/lib/python2.7/dist-packages (from virtualenvwrapper==4.1.1) Requirement already satisfied (use --upgrade to upgrade): virtualenv-clone in /usr/local/lib/python2.7/dist-packages (from virtualenvwrapper==4.1.1) Requirement already satisfied (use...

Expose more of the package directly + simplify + better composability

10

Many of the structs and their methods should progbly be exported directly and have exported members.. The way the package is constructed makes it nearly impossible to use in many...

rescreen runs on event hook when there (probably) is no relevant change to screen display configuration.

3

### Problem Description When I turn on my TV which is connected to multiple devices including my desktop computer XMonad runs 'rescreen' which causes some issues with layout being reset...