Avi
Avi
@skliper Do you mean _combine_ these (opposing) functions together, or separate out the common logic into _another_ function?
These pairs of functions are ~90% identical. There seems to be significant de-duplication possible using something like these first couple that I mocked up from the list: ```c void CS_DoEnableDisableAppCmd(const...
@skliper Can the magic number (30) just be replaced with `CFE_TIME_PRINTED_STRING_SIZE`?
> I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name...
> I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name...
> I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name...
> Concur with changes... @chillfig Justin - slight change since your approval due to a merge conflict resolution. There are now 2 separate EIDs for the different pipe creation error...
> I like this changeset, but it overlaps with other recent PRs. We should rebase it, but only after the other pending items. No worries Joe @jphickey - I'll try...
Partially implemented in https://github.com/nasa/cFE/pull/2544
I can also add a comment in for each default if it's worthwhile - something like: `/* Not currently implemented - should never get here as all cases are handled...