Thiruvalluvan M G

Results 4 comments of Thiruvalluvan M G

It turns out you don't even need to attempt a `start()`. Just instantiating `GatewayServer` is enough to prevent JVM from exiting. One needs to `shutdown()` instance to to release the...

Instead of having a new class `CustomFields` can we not define a simple `typedef`? typedef std::map There is a little bit check done in `addCustomField()` member of the new class....

Apart from the fact that this needs to be rebased, a couple of issues: - Tests don't run - Please conform to the style of rest of code. For example,...

Looks good to me. There is a minor fidelity issue though: the JSON regenerated from the compiled schema loses the non-string type. That is, in the process of `JSON ->...