Holger Stitz

Results 32 comments of Holger Stitz

We unified all dialogs and added the live preview feature with PR #265. Hence, you need to confirm the changes with the tickmark at the bottom. If we want to...

> I think this is all fine, but I do think that the default should be accept, not reject the changes. Or why should it not be like that? Can...

Maybe the icon is missleading and we need a "reset" icon? Because the tooltip states clearly that it resets all values. ![grafik](https://user-images.githubusercontent.com/5851088/126659929-7a83ef6d-5c2c-44f3-93c6-e1a0347549e8.png)

@alexsb If I understand you correctly, than this PR should not be merged. Selected rows can already be copied (introduced with PR https://github.com/lineupjs/lineupjs/pull/510). Copy all rows of a column could...

In general I agree. However, there are lots of corner cases that make an implementation difficult. Lets take the soccer example: ![grafik](https://user-images.githubusercontent.com/5851088/125073892-e8415000-e0bc-11eb-9c35-65c0d3a270fd.png) * Should users only be able to copy...

You could also check the direction of the drag operation: * vertical = select rows * horizontal in a single row/cell = select text * horizontal over multiple rows =...

Related to this is my change request in https://github.com/lineupjs/lineupjs/pull/334#issuecomment-639560277 point 2.

@sgratzl Thanks for your explanation. I understand your point. However, I agree with @puehringer that this inconsistency is hard to understand for developers that "just use" LineUp and it is...

This issue might be a duplicate of https://github.com/lineupjs/lineupjs/issues/236, but we can continue the discussion here.

Ok, we will do next week as we have a couple of releases on our list this week.