Joey Zhang comments

Results 8 comments of


                                            Joey Zhang

nmcli - Task always changed : Connections do exist so we are modifying them

Please run the playbook with `--check` and `--diff` to show the details. I guess there're some implicit connection parameter values that are not considered in the code.

Keep magic comments in the minify output for shebang and encoding

Hi @dflook, thanks for your reviewing. Even the encoding for the output has been UTF-8, Python 2 interpreter still need this magic comment to load code correctly if non-latin characters...

Keep magic comments in the minify output for shebang and encoding

Hi @dflook, do you think shebang or encoding hint should be preserved by default? If not, the minified program will not be fully equivalent to the original source. For example,...

Keep magic comments in the minify output for shebang and encoding

Hi @dflook , I totally agree that test cases are always necessary for any code changes. Nevertheless, it looks no existing test scaffold for the `minify()` function. If I understand...

Method iso.record() doesn't work if using strings as the path argument in Python 3

Pull request #21 implemented a patch to fix this issue.

ollama-ipex-llm cannot support phi4-mini

Thank you guys! I will try these Ollama variants with OneAPI.

fix: virt_cloud_instance - add boot option support for UEFI (#232)

@Andersson007 @Bob131, could you review this PR? thanks!

Idempotency when destroying a VM

Hi @computerquip-work , I just saw this issue. I think this is a common isssue for the modules in `community.libvirt` collection. Because they call the same library function for the...