Konstantin Bogdanov

@tonickkozlov yep overall looks OK, I'll make another pass today. I will check the test as well.

Can confirm, reproduced the segfault using `mysql` CLI on `v24.5.3.5` and latest `master`, looking into it. Interesting that this query does not cause a segfault using native interface, it returns...

Huh, it is not reproducible via `clickhouse-client` because of another potential bug in it. Here is a repro with HTTP: ``` curl -XPOST -H'Content-Length:0' 'http://localhost:8123/?query=insert%20into%20ch_main.t_m%20%28c_mpcnr33%2C%20c_v8s%2C%20c_l%2C%20c_jismi1%2C%20c_p37t64z75%2C%20c_uz%2C%20c_rp%2C%20c_d56dwp13jp%2C%20c_sf__xnd4%29%20values%0A%28868701807%2C%20coalesce%28%28select%20c_u3xs92nr4c%20from%20ch_main.t_nh1w%20order%20by%20c_u3xs92nr4c%20limit%201%20offset%206%29%0A%20%20%2C%20%27llwlzwb3%27%29%2C%201824351772%2C%20coalesce%28MACNumToString%28lcm%28-3%2C%20-6%29%29%2C%20%27f%27%29%29%3B' ```

Crash is no longer reproducible on the latest `master`: ``` MySQL [(none)]> use ch_main; Reading table information for completion of table and column names You can turn off this feature...

:eyes: https://github.com/NixOS/nixpkgs/pull/350377

``` ➜ cmake-build-debug git:(master) ✗ programs/clickhouse local ClickHouse local version 24.9.1.1. :) create table test (d Nullable(UInt64)) engine=Memory CREATE TABLE test ( `d` Nullable(UInt64) ) ENGINE = Memory Query id:...

@lexicalunit @rschu1ze correct, this change is necessary to build with LLVM 19. https://releases.llvm.org/19.1.0/projects/libcxx/docs/ReleaseNotes.html#deprecations-and-removals >The base template for std::char_traits has been removed in LLVM 19

@rschu1ze >Include https://github.com/ClickHouse/grpc/pull/42 in this PR as well? See https://github.com/ClickHouse/ClickHouse/pull/70412

TODO ``` /home/thevar1able/testmount/ClickHouse/src/Common/HashTable/HashTable.h:174:66: error: returning a constant reference parameter may cause use-after-free when the parameter is constructed from a temporary [bugprone-return-const-ref-from-parameter,-warnings-as-errors] 174 | static const Key & getKey(const value_type &...

@rschu1ze `clang-tidy-19` now complains about not modernizing ranges; should we apply its suggestions, or add some ignores to conifg? ``` -boost-use-ranges -modernize-use-ranges ```