Y H, Ph.D.

Results 10 comments of Y H, Ph.D.

> Patrick has a good point. IIUC this PR has two parts: > > * limited concurrency > * limited buffering > > Both of these can be accomplished by...

> This code doesn't seem to do a very good job at de-duplication. While a worker is processing a chunk, an equivalent chunk can reenter the queue. > > You...

> I support the "GossipSub Message Forensic (GMF)" approach, articulating my views as follows: > > * Network layer is clearly separated from internal messaging logic. > * By carrying...

> What I was proposing is something like this: > > Some struct like message.Message as the Flow message. ( enriched with seqno, topic. signature, key from pb.Message, and decoded...

> CI is failing though. Thanks for the approval, fixed the CI, ready to merge.

> In principle this is fine, as it can allow application specific extensions to the protocol; this is useful for testing and early adoption as a path to standarization. It...

Created the PR: https://github.com/libp2p/go-libp2p-pubsub/pull/562

@vyzo a gentle reminder for this issue; the PR is ready pending a review; thanks! https://github.com/libp2p/go-libp2p-pubsub/pull/562

Is it possible to have a tagged release of the `master` head (inclusive of https://github.com/libp2p/go-libp2p-pubsub/pull/562)?