theolivenbaum
theolivenbaum
Hi @tellarin , I can take a look but I've the impression a few of the the tests are failing due to the PR being based on master, that is...
@tellarin: Found the issue, there are some places that expect to have different objects for the same Regex value, for example here: `````csharp var regexes = new Dictionary { {...
@tellarin all fixed - was in one side the repeated Regex being used as keys in the dictionary, and finally a whitespace stylecop rule that my visual studio didn't complain...
@tellarin - no worries - all in all the changes are quite simple, just a lot of files where `new Regex(...)` became `RegexCache.Get(...)` The only significant change is the addition...
fixed a merge conflict I just noticed too with the chinese regex files
@tomaszzmuda same thing happening to us under Linux. Any chance you can get a look at it? For us it's happening with the OfficialFFmpegDownloader as well - so the [PR](https://github.com/tomaszzmuda/Xabe.FFmpeg/pull/395)...
@tomaszzmuda seems like the issue is really with the extra __MACOSX folder that is being included by mistake on the zip file by the ffbinaries project. Probably best to filter...
Totally agreed. @tomaszzmuda maybe could just release the binaries to NuGet? It should all be under the max package size. Happy to help if needed!
Still relevant
Still relevant