Thibault

Results 16 comments of Thibault

hey, I'm not part of the maintainer team, and I know your PR is old, but maybe #72 (when #73 will be merged as well) will do the trick for...

Hi, for my particular use-case, I need the middleware to be a pure ASGI middleware, since I want to use background tasks as well. According to my tests, and [starlette's...

@Kludex good catch, anyway I'm using fastAPI which have a strict dependency on 0.20.4 for now :smile: Anyway, I may open a PR in the coming days with an alternative...

For those interested, here is the associated PR for the ASGI middleware I wrote: https://github.com/laurentS/slowapi/pull/113 Don't hesitate to comment and review it if you feel so :smile:

Hello @samvr-pxl could you also share how you run your server ? is it a development server ? using uvicorn ? That could help us find the reason

Hi ! coming back to this PR that seems a bit forgotten: - I agree with @twcurrie and @laurentS here > From the library perspective, I'd rather default to the...

Hi! Feel free to open a PR, as unfortunately no-one is working full-time on this package

Not related to this PR but maybe we could implement [pre-commit](https://pre-commit.com/) on the repo, so that anyone wanting to contribute would just need to do one `pre-commit install` when first...

Hi, did you try `'["12/10seconds"]'` ? this is the output of `json.dumps(["12/10seconds"])`, guess it might work (didn't try it, sorry)

Alright, looking at the code, I think there might be an issue in the code: in `extension.py`, here is the line in charge of loading this env var (C.DEFAULT_LIMITS being...