Seth Foss
Seth Foss
Would it make more sense to add `codeception/module-webdriver` to the composer.json directly (in `require-dev`? Then step 2 could be omitted entirely.
@abdelilahdahdahi It adjusts the permission bits of the init script to allow it to be executable. It's the solution to the error you are getting: `./init: Permission denied`
The PR is still good to go, just waiting on a review.
@hanzei The problem of a more central location was already solved in another branch. All job listing commands funnel through `listJobsCmdF` in `job.go`, so simply moving the command there (required...
> A generic DRY checker could live in the `RootCmd.PersistentPeRun` function ( > > https://github.com/mattermost/mattermost/blob/6ddf796384f2154139bedaaff8f21748b261a096/server/cmd/mmctl/commands/root.go#L93-L111 > ). This function is called before all commands. > > What do you think...
Interesting, I hadn't seen that one. I'll do some additional testing, and try moving the limit check into the pre-run function you mentioned.
The golang-lint failure is useful - since we're in a new function that is no longer making direct use of `perPage`, a simple assignment is no longer sufficient to change...
@hanzei @BenCookie95 Is there some documentation on running more of these checks locally? I don't like wasting your time pushing something to the PR that fails a `lint` check.
Hey I just got to this. I've got another commit prepped, but when I tested it looks like bad values to the parameter don't even make it into this function:...
@hanzei Nope. With a negative value, `err` is still `nil`.