Jiten Patel

Results 14 comments of Jiten Patel

@pablobarrera did you get a solution to these?

@pablobarrera yeah actually I tried this code but shows me in the console and I'm not able to know should I embed that in widgets. So is there any way...

> This PR will need images with side-by-side comparisons with native, new tests, and fixes to existing tests. Sure @victorsanni! I will add images with a side-by-side comparison with native,...

Hi @victorsanni, @MitchellGoodwin, @dkwingsmt, here's the side-by-side comparison with native. | Native | Flutter | |--------|--------| | | | | | | Also, @dkwingsmt, I derived those numbers from GitHub...

Hi @victorsanni, @MitchellGoodwin as requested, here's the detailed comparison of before and after PR changes with native. **Before PR** | Native | Flutter (master) | |----------|----------| | | | |...

Hi @MitchellGoodwin, Thanks for the suggestion! I tried using `CupertinoColors.separator.resolveFrom(context)` & `final Color dividerColor = CupertinoDynamicColor.resolve(CupertinoColors.separator, context);` as recommended, but it doesn't seem to be working as expected. The divider...

> > Hi @MitchellGoodwin, > > Thanks for the suggestion! I tried using `CupertinoColors.separator.resolveFrom(context)` & `final Color dividerColor = CupertinoDynamicColor.resolve(CupertinoColors.separator, context);` as recommended, but it doesn't seem to be working...

> Is it showing as the same color as before? And is it not picking up the brightness, the elevation, or both? > > `CupertinoDynamicColor.resolve` may need to be called...

Hi @MitchellGoodwin, You’re correct that this PR didn’t introduce the behavior. The issue occurs specifically when a horizontal divider is drawn—it doesn’t resolve the color as expected _(screenshot 1.0)_. It...

Thanks for the review, @nate-thegrate! I’ve addressed all your suggestions and look forward to any further feedback you may have.