Ned Schwartz
Ned Schwartz
This is a great Workflow! I'd just love to see DOM docs in there. I tried to add in DOM docs by copying the js docs example and updating the...
This is a tracking issue for hotkey version 3 which will introduce a few breaking changes: Some of this was split from https://github.com/github/hotkey/issues/65 ```[tasklist] ### Tasks - [ ] https://github.com/github/hotkey/pull/66...
Add a special `Mod` modifier that translates to either `Meta` on Mac or `Control` on other platforms
resolves #56 ## What is this? On Mac, `Meta` (command) is frequently used as the modifier for shortcuts: on Windows and Linux `Control` is used instead. Therefor in order to...
On a Mac, the `alt` (`option`) key acts as a modifier. For example, when `alt` and `k` are pressed, the serialized event string produced on a Mac is `Alt+˚`, while...
There are many cases where we want to be able to support _either_ the `Meta` or `Control` modifier for a shortcut; as opposed to cases where we support _both_ `Meta`...
_From a chat with @jscholes off-site:_ This is a difficult sort of mechanism to make accessible for some users, because reliance on keyboard input (or tools that emulate it like...
## Problem Currently `data-hotkey-scope` only supports matching the (`event.target` i.e. the scope) as an `id`, this has a few limitations: 1. I may want to specify multiple elements as the...
https://github.com/github/details-dialog-element/runs/5240152268?check_suite_focus=true This test appears to have been failing since https://github.com/github/details-dialog-element/actions/runs/1766435305 but it looks like older runs may have been failing silently as tests were not running. See for example this...
# Problem The export for the `Icon` component was incorrect in `index.js` as it was not returning the default export. resolves #8 # What I did 1. Updated the test...