thedanielsun

Results 4 issues of thedanielsun

I have been seeing hanging get requests to Eventbrite API. Rather than try to hack my own function timeouts, I thought it would be reasonable to use requests built-in timeouts....

`threatexchange hash photo https://i.redd.it/4shux9eu3mga1.png` ``` File "/Users/daniel.sun/.pyenv/versions/3.8.12/lib/python3.8/site-packages/threatexchange/signal_type/signal_base.py", line 195, in hash_from_file return cls.hash_from_bytes(file.read_bytes()) File "/Users/daniel.sun/.pyenv/versions/3.8.12/lib/python3.8/site-packages/threatexchange/signal_type/pdq/signal.py", line 77, in hash_from_bytes pdq_hash, quality = pdq_from_bytes(bytes_) File "/Users/daniel.sun/.pyenv/versions/3.8.12/lib/python3.8/site-packages/threatexchange/signal_type/pdq/pdq_hasher.py", line 33, in pdq_from_bytes return...

pdq

Using this image https://styles.redditmedia.com/t5_17138f/styles/profileBanner_p7ne95txaxfa1.png (I think it's just black) ![image](https://user-images.githubusercontent.com/1167781/216681698-acd00a3b-f3f4-45b3-ab20-8b3e740c88a2.png) `threatexchange hash photo https://styles.redditmedia.com/t5_17138f/styles/profileBanner_p7ne95txaxfa1.png` has blank output because the hash is under the quality threshold. I kind of get the...

bug
python-threatexchange
code quality

There is a corrupt entry in the StopNCII data: `('pdq', '00000000000000000000000000000000')` While it's probably good for StopNCII to remove this data from their upstream as well, it would be nice...

bug
pdq
python-threatexchange