Simon Farre

Results 61 comments of Simon Farre

> > We're already up to 20 files. > > We could dynamically assemble the top-level XML file. I.e. given the base CPU type (aarch64, i386, amd64) and some set...

> > I think GDB does something similar under the hood. I can add this feature to this PR, or in a later PR, if we're all in agreement. >...

I'll squash when we complete the review.

> Yes if these were copied from the gdb repo they need the copyright headers. This had somehow slipped through my fingers. Addressed in https://github.com/rr-debugger/rr/pull/3934 Thanks for spotting this @sidkshatriya

> The missing visit on document::m_fullscreen_element needs fixed: https://github.com/LadybirdBrowser/ladybird/actions/runs/14411993971/job/40447984611?pr=4330#step:11:1711 > > Make sure your IDE doesn't add `""` includes. `Files that #include a missing local file: Libraries/LibWeb/CSS/SelectorEngine.cpp Libraries/LibWeb/DOM/Element.cpp UI/Qt/BrowserWindow.cpp` >...

> @theIDinside looks like the linter check is failing in idl file, it's likely an indentation issue. It should be: > > ``` > enum FullscreenNavigationUI { > "auto", >...

Fixed most of your nits & issues @ADKaster. Rebased onto master. Also changed the last commit message (one pertaining to Qt) - which can be viewed as an entirely preliminary...

These new round of changes to address nits and other things, I also threw in the implementation for `ShadowRoot`, which means that our wpt test score for `fullscreen/api` for this...

Just updating with a comment. Maybe @awesomekling can take a quick look? Would be greatly appreciated.

As far as I know, gdb doesn't use `signalfd` nor have a dedicated thread to do `waitpid` operations on, though I don't see why they wouldn't want it. The reason...