Simon Farre

Results 61 comments of Simon Farre

I think the linter may have a bug. That second commit title is not longer than 72 (it's 53 characters long), but it has appended some hash to it in...

Firefox fails because firefox has a bug. The test passed before on Firefox, because the asserts never actually ran.

@rocallahan || @khuey Does the tests run on actual hardware or some emulation? The errors are confusing; I just can't see how that can possibly be true without there actually...

Prior to this patch, I have no idea how RR informed GDB on `aarch64` that the `g` packet contains the `aarch64-fpu.xml` because the only file it ever *should have* transferred...

> Also, it looks like tests are failing in CI on x86-64? Where can I see these tests? It says "All checks have passed" here.

> @theIDinside as far as I understood the review that's nearly finished and only needs minor tweaks. > > It would be nice if this could be finished as it...

> @theIDinside can you please debug the new elements in util.h as requested and rebase, so that we may see that be integrated? Rebased it and added documentation to the...

I haven't looked at this in a long time @rocallahan but, what what I take from your last comment, is that this feature would better be served by _just_ having...

> I'll look at this in detail this week. > > The assumption that AVX-512 implies PKRU is not necessarily correct because these two features can be controlled independently by...

I guess we can assume the presence of AVX & AVX2 too (in the target descriptions), since these are very common features these days anyhow.