Marcin L

Results 32 comments of Marcin L

Hi. Is there any chance of including this in the next release? Would attaching a patch to the JIRA speed things up (as mentioned in https://github.com/apache/mina/pull/25)?

@chrjohn QFJ-981/QFJ-982 are actually a duplicate of 2016 issue QFJ-877, but there was no investigation so it can be closed once this is merged. @philipwhiuk You probably need to add...

Null checks would be good to have, but your choice. I would not worry to much about it.

How often does it happen? I tried to recreate it, but I modified the YAML script slightly to run "TimerTest" only and after 5 attempts it passed every time on...

This was always the case (at least going back 6 years back.) The validation happens in two places. One in DataDictionary and the other in the Message. The one in...

In theory you are right, but in practice there is no place in this method that can cause an exception to be thrown that is unhandled (as far as I...

Cool. I'm not able to see it on Coveralls though. Is this the right link? https://coveralls.io/github/quickfix-j/quickfixj?branch=master

Seems to wok. Uploaded successfully to Coveralls. https://coveralls.io/github/quickfix-j/quickfixj There is a problem with coverage for `quickfix.field.converter` classes. It seems that JaCoCo is not able to detect the common inclusion/exclusion for...

Local coverage after moving converters. ![coverage with converters](https://user-images.githubusercontent.com/3160158/85863338-ec087a00-b7ba-11ea-9a36-87cca7ea6373.png)