thc202

Results 1126 comments of thc202

Normally the same task would be used in all cases (assuming you want to support the same features), it doesn't matter if the task is being created/configured by the plugin...

With the regular expression you can apply the rule to several methods at once. The user can also create rules from existing alerts which would have the exact method.

A multiselect/list would restrict which methods can be added though (History filter does not show all standardised methods, nor custom ones for that matter), so multiselect and free text field?

Added some quick/obvious comments, will pull the changes and check the code more thoroughly.

The library does not seem to be in use (yet), it could be dropped from this pull request.

@chutchut ping :)

@chutchut, @psiinon, @kingthorin any objections to move this to master branch? It would be less work when merging all the branches...

Which error are you getting?

Cool, do you have any other changes pending? Otherwise could move this into master in the following days.