Andrew Stone comments

Results 5 comments of


                                            Andrew Stone

Remove python 2 support and assume we have python 3.3+

Is there any reason to restrict to 3.3+? I have type-hints locally that would be nice to get merged, but that requires 3.5+.

Remove python 2 support and assume we have python 3.3+

Is there any reason to restrict to 3.3+? I have type-hints locally that would be nice to get merged, but that requires 3.5+.

beforeRouteUpdate never calls next callback

I'd say that this is a bug, not an improvement. Consider when using ``, it becomes impossible to access the new component, so you can't inject data. See: http://jsfiddle.net/thatguystone/nypp9jma/1/

fix potential nil pointer error

It's been a while since I've looked at this project, but IIRC, each `Image` should always have a `Sel` set. Is something causing it not to be set?

Keyboards without numpads on high-end laptops

Having multiple options for keyboard layouts would be awesome. Personally, I really like the current layout of the Galago (with home/end/pgup/pgdown).