Tim Hatch

Results 84 comments of Tim Hatch

I can't autofix because it depends on a missing version of tensorflow.

A test for this should go near https://github.com/facebookincubator/Bowler/blob/master/bowler/tests/query.py#L187 To see what the lib2to3 pattern would look like, you can use `python -m bowler dump [--selector-pattern] `. The bug is probably...

That example would make a great filter, would that solve much of the use case?

Checkpoint: I have a prototype using parso -- it is not fast, fails to parse in any version with bad `# type` comments, and always obeys future imports though.

See #133 for a work-in-progress fix.

Are you just suggesting prune the captures dict? Could you give an example of where this is helpful?

The best way to do this would be alter the grammar. Some untested hints, I think you'll want to treat these like comments: 1. https://github.com/jreese/fissix/blob/main/fissix/pgen2/tokenize.py#L69 add a new regex similar...

Sure! Using a bowler script something like sample.py ```py from bowler import Query def filename_matcher(*args): raise Exception() Query(["."], filename_matcher=filename_matcher).diff() ``` and run with ```sh bowler run sample.py ``` It should...

It looks like the bug relates to lack of types, bowler needs a fix something like https://github.com/thatch/Bowler/commit/16113033ea1041d66d2637c43faa251db9a43914 (but with tests!)

Is there a blocker left on this PR?