Valérian Rousset
Valérian Rousset
From the [CAS v2 documentation](https://apereo.github.io/cas/6.0.x/protocol/CAS-Protocol-V2-Specification.html#31-service-ticket), there is no need to validate the content of the ticket, the only relevant check is that it needs to begin with "ST-". `tests/mod_auth_cas_test.c:getCASTicket_test` actively...
> The check was added because there is/was essentially no cases where a non-ASCII ticket in that form was found in any CAS server implementation, and this made reasoning about...
You accept a single underscore here, but for example, in `blscosi/protocol/protocol_test.go`, three are sometimes used. The one below looks better to me but I didn't test it. ``` ^(_|Test[A-Z])[a-zA-Z0-9_]+$ ```
> Hmm - that one allows `_hello_` and I'm not fan of the `_5_9` in the test-name - those should be done using a for-loop or so... I agree, that's...
> OK, we're getting there. Currently you disallow all public methods, which is a bit harsh. I know you prefer not to expose too many methods, but none? Sorry, couldn't...
Right! That's way better! I think it's the right one :smile: I'm using `find -name '*.go' -execdir grep -h '^func' {} + | grep -vE '^func( \([^)]+\))? ([a-zA-Z0-9]+|Test[a-zA-Z0-9]+_[a-zA-Z0-9]+)\('` to test...
> I don't think it is the coverage it is complaining about, but the "duplicate lines on new code". Correct, from what I gather from the checks page. > However,...
FYI, there is also https://github.com/JavierZunzunegui/zerrors which is stable, see [discussion on golang](https://github.com/golang/go/issues/29934#issuecomment-591492106).
> @tharvik why `errors`? Don't you like the trace feature of `xerrors` to know where it all happened? I meant the `errors` from https://github.com/cockroachdb/errors But yeah, I prefer the basic...
> `context 1: context 2: context 3: context 4: actual error` > > I first have to search for each context, decide if it's actually a problem, and then move...