clean-code-dotnet

clean-code-dotnet copied to clipboard

Adjustments to the examples "Use getters and setters" ("Objects and Data Structures")

5

- added missing type to constructor - fixed mistake of signature name - changed double to recommended "decimal" type for money operations - corrected exception message type from char to...

jarosal

Hi! I've spotted typo in section "Functions" paragraph "Functions should only be one level of abstraction" in point "Good". It's saying: ```c# class BetterJSAlternative { private string _tokenizer; private string...

AdmiralReality

English is my second language and sometimes I dont really get the meaning of some phrases. I'm trying to understand the part that says to always use domain name in...

eliumoraes

ShowList funtion in DRY section does not return a list

1

ShowList funtion should return an object of List, currently does not return anything public List ShowList(Employee employees) { foreach (var employee in employees) { var expectedSalary = employees.CalculateExpectedSalary(); var experience...

mdgr3301

fix typo "is an worker"

1

Fix typo "is an worker" in Interface Segregation Principle (ISP) section

mdgr3301

SirFX

As a code reviewer, I would like to share URLs to specific rules in pull requests I'm reviewing. In order to do that, each `` element for each rule/concept must...

yor-so

SOLID. Liskov Substitution Principle (LSP). Example incorrect.

1

Drawable RenderLargeRectangles(_Rectangle rectangles_) { foreach (rectangle in rectangles) { rectangles must be array, not **Rectangle**

VitaliyPavlyukov

Fix comment

SirFX

fix a misspelling.

omid-ahmadpour