clean-code-dotnet icon indicating copy to clipboard operation
clean-code-dotnet copied to clipboard
verified publisher icon thangchung

Adjustments to the examples "Use getters and setters" ("Objects and Data Structures")

Open jarosal opened this issue 3 years ago • 5 comments

  • added missing type to constructor
  • fixed mistake of signature name
  • changed double to recommended "decimal" type for money operations
  • corrected exception message type from char to string

jarosal avatar Jul 13 '22 16:07 jarosal

I propose to change the name of PR and description.

Title: Adjustments to the examples "Use getters and setters" ("Objects and Data Structures") Description:

  • added missing type to constructor
  • fixed mistake of signature name
  • changed double to recommended "decimal" type for money operations
  • corrected lead/trail symbols to C# codestyle

dmitryvhf avatar Jul 15 '22 15:07 dmitryvhf

Great suggestions, done!

jarosal avatar Jul 15 '22 15:07 jarosal

@dmitryvhf who has the rights to merge?

jarosal avatar Jul 15 '22 15:07 jarosal

@dmitryvhf who has the rights to merge?

Check another merge's. I think only Author. Forget and waiting. Not soon, not never. :)

dmitryvhf avatar Jul 15 '22 18:07 dmitryvhf

@thangchung mind taking a look?

jarosal avatar Jul 16 '22 13:07 jarosal