Tim Golen
Tim Golen
:+1: I stopped using this because the lack of a destroy method was tearing things apart.
Marking as external to start getting proposals
Closing this out now.
Yeah, It looks like it is probably the backend not doing a very thorough job of detecting attachment links. The code is here: https://github.com/Expensify/Web-Expensify/blob/1fbdfc6b3fa70e59e502f24edb1e3af21cdfe4e9/lib/ReportUtils.php#L1716 (private repo), but it looks like...
I can work on it this week, but I'm curious about what we think the regex should be changed to. cc @AndrewGable @iwiznia @flodnv @cead22. This would be my suggestion:...
Honestly, there is a lot in this regex that I don't understand, so I'm very open to any improvements. > `href=\"[^>].* I think . should not be there, we want...
I guess that would be another solution to it as well. I see right now we are replacing that text on the string `$sanitizedComment.' '.$attachmentHTML;`. If we only did the...
OK, cool. Thanks! So, this is my updated regex: ``` ]* href=\"[^>]*expensify.com\/chat-attachments[^>]*\">[^
@michaelhaxhiu no worries on this one. It's going to be an internal fix. @iwiznia Ah yes, thank you! Missing that one period to escape
All checklists are complete, removing the emergency label