Tiago Matias

Results 16 comments of Tiago Matias

I just came across this limitation. We need to be able to deploy a package (dist/*.*) in multiple environments without having to recompile the whole thing in order to establish...

We're using Atlassian Bamboo as a build and deploy tool. I just asked the programmers to stuff all the configuration variables (mainly URL's) in some settings.json and modify the application...

Thank you for the first look at this @bachya. It was indeed in a very rough state. I cleaned some of the issue and will ping you when I manage...

> Per [my previous comment](#discussion_r1041392490), I would recommend that you do a reauth flow in a separate PR—this PR already has plenty in it. Will do.

@bachya I cleared up the issues. I changed `async_unload_entry` a bit and during testing I noticed that when removing the integration and then adding it again the entities do not...

@bachya I fixed the problem with unloading the integration. It was a stupid error where I was using a class variable to store my entities. I also updated the code...

Hi @bachya, Are there any other tasks you want me to work to help with the review?

What are the test coverage targets for files other than `config_flow.py` ?

> > What are the test coverage targets for files other than `config_flow.py` ? > > Depends on your objective. Config flow tests are required; (almost) everything else is discretionary....

@bachya Added a couple more tests and fixed minor issues found during tests