Tianyu Geng comments

Results 22 comments of


                                            Tianyu Geng

Add workspace_prefix_for_pinned_deps

Hi @cheister , can you take a look at this change? Thanks!

Add workspace_prefix_for_pinned_deps

Hi @shs96c can you take a look at this?

Add workspace_prefix_for_pinned_deps

> Apologies for the slow review on this. Here now! > > First comment: if you want a prefix, then I'd suggest defaulting to the repository rule's `name`. Secondly, if...

Add workspace_prefix_for_pinned_deps

gentile ping @shs96c

Report build error if target dependency chain contains conflicting constraints

Any hints on how I can detect this with a cquery script?

tilix --quake toggle behavior

How about just hide the terminal upon receiving 'tilix --quake' if the terminal is not hidden (assuming the terminal should know whether the window is being drawn)? I don't care...

Add workspace_prefix_for_pinned_deps

Any updates? @shs96c

Support index manifest to push multi-arch container images

What does it take to get this merged? @uhthomas can you give an update?

spr diff: "an unknown git error occurred"

I encountered this too. `spr diff` can create a new PR given a new commit. But after amending it and try to use `spr diff` to update the PR, I...

broken run with manifest jar

I am hitting this problem as well. But looks like with Java 9+ the problem can be solved with `use_argument_file_in_runner = True` when registering the scala toolchain. Digging deeper it...