Thomas Frederiksen
Thomas Frederiksen
Great work @pfebrer ! Overall it looks great to me. However, I am not fully convinced about the use of imaginary numbers to specify "open" structures. I think it follows...
> Great job! Minor changes here and there. @tfrederiksen the name of the function, what do you think? I think it is good (and relatively short) as it is. In...
> * **At the beginning of the unit cell**: The configuration of the initial string forces the creation of completely different ribbons. One **can't be related** to the other just...
> Oooh ok I understand now, so > > ```python > graphene_nanoribbon([(7, 2), (11, 2)], open_start=True) # or invert=True > ``` > > would be the old > > ```python...
> > Additionally, in my opinion it is not very clear from the user perspective if a given "column" should be denoted "closed" (real) or "open" (imaginary). It seems ambiguous...
> > What do you mean by second case? The meaning of shift would then have to refer to half the lattice vector in y. > > Hmm ok, then...
@pfebrer , what about a quick chat on discord now?
Looks great!!! I agree that it would be very useful to have this in `sisl.geom`. I have also been playing with heterostructures, but my function is not very sophisticated (can't...
@pfebrer , since one is typically concerned with periodic structures, wouldn't it be simpler to create the "open" structures from the "closed" ones by shuffling a single "column" from one...
> I don't know exactly what you mean. Do you mean doing so when the heteroribbon is completely build? There are cases in which both ends do not have the...