Theodor Fiedler comments

Results 14 comments of


                                            Theodor Fiedler

Fix: preserve datetime precision after Timex.shift/2

@bitwalker is this a change you'd be considering for Timex?

Implement calendar callbacks for shift/2 on calendar types

Thank you @josevalim and @kipcole9, appreciate the reviews and thoughts made around that topic! I like the idea of the Duration type, and actually have needed this sort of shift...

Implement calendar callbacks for shift/2 on calendar types

> Negative time scale components are permitted per ISO-8601-2 Thanks for sharing that, glad to read it's generally supported! > But the output type is indeed clearer. This is actually...

Implement calendar callbacks for shift/2 on calendar types

> Plus, I would rather prefer to pass a Duration to Calendar.ISO.shift_date, if we ever have such a type, rather than a keyword list. That's my suggestion in 2). It'd...

Implement calendar callbacks for shift/2 on calendar types

> if I specify Time.shift(time, years: 0), should it raise? Given the plan would be to add the `Duration` type first i think all fields should be required, as the...

Implement calendar callbacks for shift/2 on calendar types

Yes, sorry i misread your initial question actually, unset fields should be treated as zero :) thanks for these elaborate notes @kipcole9 especially on the topic of weeks!

Implement calendar callbacks for shift/2 on calendar types

FWIW i've dabbled a bit more with this branch: https://github.com/elixir-lang/elixir/compare/main...tfiedlerdejanze:elixir:date-shift - Introducing Calendar.Duration - Introducing Calendar.shift_naive_datetime/2 - Supporting shifting dates by hour/minute/second/ms I am wondering if 1) should the Duration...