Brian Lewis comments

Results 5 comments of


                                            Brian Lewis

Run pylint as a required check in Travis CI

Thanks for this great library! The license change makes complete sense to me, as I'm sure there are many people who would want to use `pygam` for projects that are...

Run pylint as a required check in Travis CI

With respect to this PR, I removed the `/test/` directory from code coverage (as these lines were guaranteed to run). Unfortunately, this reduces the overall coverage of the project, causing...

Consider using a faster library for parsing dates and datetimes

Just confirmed that the results are similar with Python 2 (`9.54 µs` vs `153 ns` using 2.7). I definitely understand the desire not to introduce extraneous dependencies. If there's a...

Exit early for STRING datatypes

Good catch! Should be fixed now.

Selecting from decimal (18,6) return NaN in pandas

Note that in the second example you are avoiding `pd.read_sql` entirely, suggesting this method might be causing the problem. I suggest fetching the rows from the database using the Teradata...