Tom Erik Støwer comments

Results 77 comments of


                                            Tom Erik Støwer

Fix conditional requirement on privacy and terms last_updated

+1 for Entur

Improve performance: Push for the usage of ETag/If-None-Match

Unfortunately no progress yet @tdelmas but it's on the horizon :)

Improve performance: Push for the usage of ETag/If-None-Match

Implementing this between OpenTripPlanner (client) and entur/lamassu aggregator (server), we observe that around 90% of requests are handled with 304 Not Modified response.

Mismatch rental_apps OPTIONAL vs CONDITIONALLY REQUIRED

Just for clarity, the json schema doesn't mention this since it can't have cross-file references. But the validator has a rule for it. Presumably because the requiredness property is considered...

Mismatch rental_apps OPTIONAL vs CONDITIONALLY REQUIRED

Does it actually make any sense *not* to provide rental_apps when you have rental_uris?

fix(hld): use correct path for global slash commands

I don't know if this is the correct solution, as I'm new to this codebase, but it works (tm).

Minimum age requirement

Entur votes in favor and will implement it.