Fix conditional requirement on privacy and terms last_updated

[richfab]

What problem does your proposal solve?

Fixes https://github.com/MobilityData/gbfs/issues/677

privacy_last_updated and terms_last_updated became "REQUIRED" in v3.0 by mistake.

Indeed, it causes an inconsistency with privacy_url and terms_url which are "OPTIONAL" values.

What is the proposal?

Make privacy_last_updated and terms_last_updated "Conditionally REQUIRED" again.

Is this a breaking change?

• [ ] Yes
• [x] No
• [ ] Unsure

Which files are affected by this change?

system_information.json

Thank you @hbruch for raising this issue 🙏

[richfab]

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Wednesday, October 30, 2024. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

[futuretap]

+1

[tdelmas]

+1 for Fluctuo

[cmonagle]

+1 for Transit

[testower]

+1 for Entur

[richfab]

💁 Voting on this PR closes in 2 calendar days. Please vote for or against the proposal before 11:59PM UTC on Wednesday, October 30, 2024, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

[richfab]

This vote has now closed, and it passes!

Votes in favor:

• Where To? / FutureTap (consumer)
• Fluctuo (consumer)
• Transit (consumer)
• Entur (producer)

There were no votes against.

~~This change will be part of v3.1-RC2, planned to be released this month (Nov 2024)~~, as per the version release cycle in the governance. EDIT: In order to fix this inconsistency in the spec due to a typo as soon as possible, the change will be applied directly to master.

Thank you for your involvement in the GBFS spec 🙏

[richfab]

In order to fix this inconsistency in the spec due to a typo as soon as possible, the change will be applied directly to master.

Note that the JSON schemas for v3.0 and v3.1-RC are not affected by the typo. Which means they don't need to be updated and neither do the validator and the models since they are based on the JSON schemas.

[hbruch]

@richfab I wonder what happened to this issue/PR, as terms_last_updated and privacy_last_updated still are REQUIRED in the current spec version: https://github.com/MobilityData/gbfs/blame/ae4076a7326059d44cf031468704eca634e9dded/gbfs.md#L516-L518

~~Could you please reopen this issue, if necessary?~~

Ah, I see that the tag v3.1-RC still points to an earlier commit. I suggest to release v3.1-RC2 or something like that (I just received a feed providing terms_last_updated and privacy_last_updated without specifying terms_url and privacy_url and wondered why...

[richfab]

Hi @hbruch,

v3.1-RC2 will be released in May (as per the governance). It will include this change.

In the meantime, I recommend redirecting v3.1-RC producers to the up-to-date spec on master.

I hope this solution works for you.

Thank you, Fabien