Tomasz Elendt

Is this `report.SelectiveJSONMiddleware` really needed though? This (and many other similar cases) could be solved with simple "conditional middleware": ```go type ShouldForward func(*http.Request) bool func ConditionalMiddleware(predicate ShouldForward, first, second http.Handler)...

> This form doesn't work because we can only decide whether to log *after* a request has been handled. Ah, so you want to decide based on properties like ms,...

@ohookins: That's quite common problem, not only present in handy but in most libs wrapping various "upgradable" interfaces. Here's a good read about upgradeable interfaces, the problems they solve and...

@dudleyf: if your fix really makes it work with recent version of node please increment node version in package.json as well.

@dudleyf: package.json specify node version as "0.4" and because of that it's impossible to install node-jsdoc-toolkit on any other node version using npm. Because this bug report is about "matching...

Apparently there's a fork of this project in npm registry that has all already mentioned fixes (`require("vm").Script` + node version change in package.json). It's called **jsdoc-toolkit** (@p120ph37/node-jsdoc-toolkit in npm registry...

@gigafied: I still don't get one thing. How is it possible, that the latest version of **jsdoc-toolkit** in npm registry is different (different number version - 0.0.2 not 0.0.1, fixed...

That's a redis-node-client bug. To be compatible with current trunk version there should be: this.conn = new net.Stream(); instead of: this.conn = new process.tcp.Connection();