Tom Gundersen

Results 104 comments of Tom Gundersen

Could `ignition_data` be called just `data`? As it is already in the `ignition` section. In general, how does this compare to how CoreOS handles ignition configuration? Do you have any...

Thanks for our input on this @cgwalters and @jlebon! I think you are right @7flying , that we want to make any customisations (and hence ignition insertion) at image build...

> I think it's not really important to match the same mechanism right now; i.e. I would definitely not block on it. It's something that can be done later. Yup,...

> Great PR 👍 . I like how you hooked up all the contexts in the worker jobs and internal cloud provider APIs. Thanks! > I have one request: I...

> I noticed that there are many cases in worker job implementations `Run()` method which is returning `nil` even when an error is set in the job-specific result structure. Since...

D'oh! I should not have merged PR #3161 first, that's sort of misleading as it is now. @ondrejbudai should I revert the other merged PR? I guess these two should...

What's the behavior of the weldr api if the backing job is gone? Is this a behavioral change? If so: do we want it? Is it necessary? I wonder if...

> I wonder what's the correct solution: > > 1) Make a user in a commit a hard error - basically don't accept such a request. > 2) Keep the...