technicated

Results 5 comments of technicated

Fixed `Message::parse()` regex to handle both multiple placeholders and deeply nested ones

@vjik this will not work, since the value `'p2'` would not be captured (capture groups would be `'p1 {p2}'` and `'p3'`). However, I checked and this would also fail with...

Fixed `Message::parse()` regex to handle both multiple placeholders and deeply nested ones

@samdark Does this also imply that support for "nested" placeholders (e.g. `{a{b}c}` in one of the tests) should be dropped? Given that to align with the specification, placeholder names should...

Fixed `Message::parse()` regex to handle both multiple placeholders and deeply nested ones

With this bench class (which I hope is a correct implementation with no gotchas): ```php #[Iterations(10), Revs(1000), Warmup(2)] class MessageParseBench { private function operation(string $regex, string $message, array $context): void...

Fixed `Message::parse()` regex to handle both multiple placeholders and deeply nested ones

@samdark @vjik I have updated the PR by conforming to PSR-3, using the regex `\{([\w\._]+)\}` (variation of that suggested above, I only added the underscore). I have therefore removed support...

Fixed `Message::parse()` regex to handle both multiple placeholders and deeply nested ones

I’ve updated `CHANGELOG.md` with entries under version `2.2.1`. **However:** should this change be considered backward-incompatible? Users who relied on nested placeholders will experience broken messages as a result of this...