Tim Deeb-Swihart

Results 27 comments of Tim Deeb-Swihart

I confirmed this: changing the required `buble` version to `0.19.7` causes `x0` to work.

[This may have just happened in CI](https://github.com/temporalio/sdk-go/actions/runs/6227934624/job/16903653066): ``` 2023-09-18T21:09:05.0968374Z WARNING: DATA RACE 2023-09-18T21:09:05.0968666Z Read at 0x00c000250fc0 by goroutine 6063: 2023-09-18T21:09:05.0968983Z runtime.mapaccess2() 2023-09-18T21:09:05.0969463Z /opt/hostedtoolcache/go/1.20.8/x64/src/runtime/map.go:456 +0x0 2023-09-18T21:09:05.0969904Z go.temporal.io/sdk/internal.(*commandsHelper).addCommand() 2023-09-18T21:09:05.0970610Z /home/runner/work/sdk-go/sdk-go/internal/internal_command_state_machine.go:929 +0xb6 2023-09-18T21:09:05.0971095Z...

> > This PR has a delta of nearly 8000 changed lines (I'm lazily summing additions and subtractions). > > Can you break this PR into a stack for your...

> I guess there are a few failing test cases, so this might be tricky for me to debug. :/ But if we can make this work, or at minimum...

> > I saw in our history that we've had other issues with ? and mysql8 and this seems related > > I'd be interested in hearing about it. >...

It looks like only our visibility code is failing which is interesting, hrm.

> > I'm assuming you haven't had anyone running mysql8 try this change yet, as it'd have broken otherwise > > We run all mysql8, but we don't have a...

Aha, it's https://github.com/go-sql-driver/mysql/issues/819. Our visibility schema embeds the memo as a `[]byte` which can't be used with `interpolateParams=true` for a JSON field. These queries are hard-coded and can be trivially...

The simplest approach is actually to track the Memo as `json.RawMessage` since the mysql driver handles that directly. That's simpler than manually preparing all our statements while should still let...

We're on the same page there. I'm asking around our team _just in case_ someone can think of something but I'm testing a patch that'll allow this to work at...