Taiwon Chung comments

Results 13 comments of


                                            Taiwon Chung

Private Provides

Internal Ref: GO-1736

deadlock when use with lumberjack in multi goroutine

Could you provide a specific repro for this issue?

fx.OnStart, fx.OnStop doesn't work with named dependencies (using fx.ResultTags)

Hey, sorry I missed this. Yeah, I think making it less verbose could be a valid improvement on this (as a syntactic sugar), but meanwhile we can probably close this...

adds fx.From annotation

This has been completed with #990.

Intercept provided values

I agree with @JacobOaks that this is probably fine, but we should clearly document that those values in `CallbackInfo` shouldn't be modified.

Intercept provided values

Before we add a whole new top-level API for registering a global callback for all providers, could you consider adding the constructed values into CallbackInfo? I think it would be...

Generating mocks (reflect mode) fails if interface contains methods with generic types

@cebilon123 You can submit a PR if you have a fix. We welcome any contribution.

Add call stack to unexpected mock call

I agree with @JacobOaks that skipping internal callers could be better.

Generate typed Times for mocks

I'm not really sure what kind of benefit this brings. Could you explain more in detail why this feature is needed?

Generate typed Times for mocks

Thanks for the detailed explanation! I'll bring this up to the team.