Sebastian Werner

Results 13 comments of Sebastian Werner

As a quick summary, I added the changes @kaakaa suggested. Also, I extended the test for this functionality as it did not do much before :sweat_smile:.

@hanzei No but it's the same for me on some devices. I think it depends on some font scaling thing thats outside of the control of mattermost. On mobile it...

Hello, I had some time on my hands and, based on the ideas of @hanzei and @kaakaa, I implemented something with images instead of ASCII. Since SVGs don't work, I...

@bpetit tested out the version in dev on our cluster, and nothing broke :) I did not have time to check if the data produced made sense overall the fix...

> @tawalaya Do you want to continue working on the PR? I didn't pressure this further as it was unclear if we wanted the ASCII method (needs a decision maximum...

Hi there (@kaakaa, @hanzei), I've reworked the PR as suggested, focusing on the ASCII part. Thanks to @mickmister for helping with fixing an issue with the web app part of...

@kaakaa I've looked into it. I've already addressed the first two points. The last one (`--progress-bar`) started to work on, but since it affects the command options, it has a...

Hi there, I've implemented the suggestions. Have a look. The current test is a bit "hacky" tbh. feel free to improve it using the mocking features used in the other...

We are running `v1.29`. It could also be a different reason why the pods don't show up. However, the deprecation of the `kube-openapi` API will be an issue sooner or...