Joey Wilhelm

I'm initially pretty hesitant to implement this. It is currently pretty well documented that these use regular expressions, and regexes are currently the convention throughout this application. For example, in...

Sadly, this is not yet possible :( https://github.com/github/roadmap/issues/94 This is currently slated as a "Future" item in GitHub's [roadmap](https://github.com/github/roadmap/projects/1#card-42486677), so it looks like Q3 2021 is the earliest it would...

@pmevzek-godaddy With #5 fixed, the default patterns now live within the `tartufo` codebase itself. Are these patterns something you would be willing to contribute? They live here now: https://github.com/godaddy/tartufo/blob/main/tartufo/data/default_regexes.json

I actually had some thoughts on this while I was driving earlier. There have been some things bothering me about this entire code base, including passing around so many different...

I think, with this much fundamental change to the structure of the code and the internal API, we're talking a major version bump to 2.0. And yes, I definitely like...

I'm moving this to version 2.1; I don't think that the whole org scanner is a blocker for v2.0, even though I've been working on the underlying code restructure to...

This does sound like a great idea! Thanks for starting the work on this @dclayton-godaddy. I think that there are a few things we are going to want to work...

> I'd also have to reference another non-standard that got past the "single character" reviewers... https://github.com/godaddy/tartufo/blob/master/tartufo/cli.py#L97 This was a choice made specifically after a design discussion, to avoid another common...

That `git add -p` example actually brings up another point: There should probably be a `q` option to quit out.

Hi @mrubino-godaddy, thanks for reporting this! Is there any chance you would be able to take a stab at a PR for an improved regex for this purpose? The regexes...