Michaël Zasso
Michaël Zasso
You can only use `yield*` to delegate to other generators in `co`. The reason is that the `throw` call (made by `co` because of the rejected promise) is propagated to...
@bnb what's the next step?
@mcollina the documentation says that we use fsevents on mac: https://nodejs.org/dist/latest-v17.x/docs/api/fs.html#availability What is buggy about what we do? Is there an issue about it?
What I understand from https://github.com/nodejs/node/issues/40429#issuecomment-1028912410 is that we should be able to just use `fs(Promises).watch`.
Related failures: https://ci.nodejs.org/job/node-test-commit-arm/41957/nodes=rhel8-arm64/console https://ci.nodejs.org/job/node-test-commit-arm/41957/nodes=ubuntu1804-arm64/console https://ci.nodejs.org/job/node-test-commit-arm-debug/2195/nodes=ubuntu1804-arm64/console ``` 02:30:42 ccache gcc-8 -o /home/iojs/build/workspace/node-test-commit-arm-debug/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/ssl_ciph.o ../deps/openssl/openssl/ssl/ssl_ciph.c '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_HAS_QUIC' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_HW' '-DOPENSSL_API_COMPAT=0x10100001L' '-DSTATIC_LEGACY' '-DNDEBUG' '-DOPENSSL_USE_NODELETE' '-DOPENSSL_BUILDING_OPENSSL' '-DECP_NISTZ256_ASM' '-DKECCAK1600_ASM' '-DOPENSSL_BN_ASM_MONT' '-DOPENSSL_CPUID_OBJ' '-DPOLY1305_ASM'...
Automated workflows are only a subset of the checks. I requested a new full CI run.
@nodejs/platform-arm
> > I'd still love an explanation (per [#44095 (comment)](https://github.com/nodejs/node/pull/44095#discussion_r937425378)) for why having the snapshot name be implicit/optional is "simpler" than requiring an explicit one for this first iteration. >...
@MoLow Please add the `semver-minor` label to PRs that add new features.
Maybe @nodejs/v8 can have a look?