T.J. Alumbaugh
T.J. Alumbaugh
Ah I see. I haven't looked at all of the source, but my instinct is that you could have one source that is compatible with 2 and 3.
@rickecon thanks so much for fixing the codecov situation! I'm looking at all greens here. If this looks good to you, let's merge! also, agree on the idea of dropping...
> Also, note that this PR is running both push and pull tests because TJ made a branch on this OG-Core repository. TJ, all the CI tests will run twice...
> @rickecon, @talumbau does include the else (in line) and offers an improvement over my changes in that it will use the global variable if it is not `None`. Correct....
> @jdebacker and @talumbau. OK. Then are we ready to merge this PR and close Jason's PR #916? It looks good to me. And I am excited to move on...
I found this issue when trying to test https://github.com/PSLmodels/OG-Core/pull/925 which should provide a speedup for TPI.
I confirm that when I ran the example `run_og_usa.py` in a terminal using the desktop environment of my Linux workstation (I think it's based on Gnome), the code was able...
thank you! Will try and report results.
Thanks for opening this issue. I agree it looks like this is the right call, but I was going to ask you both to try a run with this setting...
Thanks for trying out the API. We want the API to work with essentially any open model, so let's see if this is a config issue. Can you show the...