Alex Leites

Results 22 comments of Alex Leites

Observed the same, nginx-opentracing 0.8.0, nginx 1.13.6 (OpenResty 1.13.6.2)

@SchoolGuy: No, it is not. #33 is not very precise about exactly what deletion is failing, but it is most likely about deletion of Helm releases via deletion of `HelmChart`...

I don't think this will work, as most cloud providers (unlike the test one) check for `MinSize` right away in their `DeleteNodes` implementations. Meaning that respecting `MinSize` is a more...

> @tallaxes, would you be interested in helping out on this one? Yes, absolutely - assuming you are referring to ironing out (and maybe ultimately documenting) what it takes to...

Makes a lot of sense to me. @charliedmcb, @mattchr - note that the plan is to use https://github.com/aws/karpenter-core/pull/786 as a stepping stone.

> In either case, I think we want to hash on these values, so I think our current behavior is correct. Why do we want to include the reference itself...

> For instance, the AWS provider tags instances with the karpenter.k8s.aws/ec2nodeclass tag and if Karpenter didn't drift when there was a change in the nodeClassRef, this tag wouldn't change for...

> Out of curiousity, what's the benefit for you of not drifting on changes to the nodeClassRef? This is cited as one for the reasons for having to do drift...